Skip to content

Fix common errors. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
t-karatsu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix common errors. #1

t-karatsu wants to merge 1 commit into from

Conversation

@t-karatsu
Copy link

@t-karatsu t-karatsu commented Dec 26, 2019 •
edited
Loading

Hello. I found two errors building aspa, so suggest source fixes.
Could you check if it is the right fix?

  • defined new member 'Vec_value_type' in 'self' namespace.
     460    In file included from ../src/mtl_headers/mtl/matrix_implementation.h:27:
  >> 461    ../src/mtl_headers/mtl/linalg_vec.h:135:21: error: no member named 'Vec_value_type
            ' in 'linalg_vec<RepType, RepPtr, NN>'
     462            while (*i == self::Vec_value_type(0)) ++i;
     463                         ~~~~~~^

I defined Vec_value_type as a member of linalg_vec namespace with reference to other header file src/mtl_headers/mtl/dense1D.h.

  • fix narrowing error.
  >> 915    ../src/utils/toolbox/database/HDFDatabase.cc:689:24: error: non-con
            stant-expression cannot be narrowed from type 'int' to 'hsize_t' (a
            ka 'unsigned long long') in initializer list [-Wc++11-narrowing]
     916          hsize_t dim[] = {nelements};
     917                           ^~~~~~~~~

I did a typecast for nelements to 'unsigned long long'.

@t-karatsu
Fix common errors.
799b3c9 
* defined new member 'Vec_value_type' in 'self' namespace.

* fix narrowing error.
@t-karatsu t-karatsu mentioned this pull request Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@t-karatsu